Feature #3149

[PATCH] Relation role completion and improved keyboard navigation

Added by Travers Carter about 4 years ago. Updated almost 4 years ago.

Status:Feedback Start Date:10/23/2010
Priority:Normal Due date:
Assigned to:- % Done:

0%

Category:-
Target version:0.18.0
Resolution:

Description

The attached patch (against current git) implements autocomplete for relation member roles along with improvements to the keyboard navigation in the member role table view of the relation properties dock, please consider applying it.

Changes:
  1. Autocomplete/combobox is supported for relation member roles
  2. When editing a relation member role Enter and Tab move to the next member's role field (instead of the current member's name field)
  3. When editing a relation member role Shift+Tab moves to the previous member's role field (instead of the previous member's name field)
  4. Autocomplete of tag names (keys) no longer offers tags that already exist in the current view (this feature was present already from my patch in Issue #2716 but didn't work correctly)
  5. Autocomplete for the "name" tag is restored (see Issue #1675) since the data is already tracked in the document I'm not convinced that offering it for autocomplete really has a significant memory impact, but I can update the patch to exclude it again if necessary.

merkaartor-relation-role-completion.diff (17.7 kB) Travers Carter, 10/23/2010 02:04 pm

History

Updated by Travers Carter about 4 years ago

I have found a few bugs in the original patch, I'll attach an updated version in the next day or so.

Updated by Chris Browet about 4 years ago

  • Status changed from New to Feedback

Trav,

Do you still plan to update the patch?

Updated by Chris Browet almost 4 years ago

  • Target version set to 0.18.0

Also available in: Atom PDF